-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NLDAS model choice (no breaking changes) #2
Added NLDAS model choice (no breaking changes) #2
Conversation
This is my first ever contribution to a repository that's not my own. I really tried my best to follow the contributing guidelines. There was a small issue with the conda environment where There are no breaking changes for people who already use the library. The basic idea was to create another dictionary containing the variables for NLDAS 2.0 and update the utility functions to handle that. The output from the API is slightly different so I had to modify Obviously feel free to edit things to your liking! |
Congratulation on your first PR to an open source project, hopefully, one of many! Overall, you did a good job. I just added some comments to match the overall structure of HyRiver packages.
That's strange, never had this issue. Will look into it. For now, we can keep it.
That's the best to do it.
Overall, the implementation is good, but there are some user interface issues that can help make it much easier to work with. |
Thank you for the quick feedback! I will make the adjustments you suggested. I'm not sure about the procedure. I assume I can add a new commit to the branch? (I'm always worried to make mistakes with Git) |
Yes, just commit and push your changes to the same branch that you started the PR with, and they will be automatically shown here. |
…tps://github.com/LucRSquared/pynldas2 into bugfix-or-feature/choose-alternative-nldas-model
This should do it! Sorry for the multiple commits, I had left a test notebook in there. Somehow my local environment setup was a bit weird as I had the main version of pynldas2 in my dev environment and it would not import the one I was currently working on I had to recreate the environment by removing the Also, the API was a bit wonky today for the While yesterday it was working fine so maybe it's just a temporary server issue. I updated the test file according when testing the |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Having multiple commits are normal and even recommended for commit that have different purposes. So, don't worry about it. The modifications look good to me, thanks for taking the time and finalizing the PR! Regarding the issue with the environment, you didn't have to remove the line related to the main |
nox
passes.pre-commit run --all-files
HISTORY.rst
.