-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power, torque, and negative speedpoint limit #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dopp-IO
reviewed
Apr 11, 2024
Dopp-IO
reviewed
Apr 11, 2024
Dopp-IO
reviewed
Apr 11, 2024
Dopp-IO
reviewed
Apr 11, 2024
Eric has also looked over this in person. This can be merged as soon as we get to test it on the car. |
Tested this last night and discovered/fixed problems with the power calculation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces and completes the limiting functions that were present in the torque controllers.
These have been placed in the TCMUX since they should be applied to all controllers and all drivetrain requests.
The Power limit is a simple powerlimit akin to the one run on HT07. When calculated mechanical power is above the predetermined 63kw mechanical power limit it will scale down all motor torques to be below the 63kw limit while preserving ratios as determined by the torque controllers.
The torque limit works in a similar manner but takes the average torque value across all motors. This will effectively limit the torque output of our motors so that the average torque of all motors at any point in time is the same as the dashboard/ecu torque limit.
The negative speedtest limit function just takes the max of speed setpoint values above 0, preventing the car from commanding backwards motion
closes #66
closes #71