Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde improvements #29

Merged
merged 1 commit into from
Feb 24, 2023
Merged

serde improvements #29

merged 1 commit into from
Feb 24, 2023

Conversation

joeroback
Copy link
Contributor

  • adds serde human readable bytesize support
  • fixes several clippy warnings with u16/u8 and is_digit/is_ascii_digit

resolves #27

@joeroback
Copy link
Contributor Author

bump on this? anything i can do to help this along?

@v0y4g3r v0y4g3r mentioned this pull request Jan 10, 2023
Merged
2 tasks
@v0y4g3r
Copy link

v0y4g3r commented Jan 10, 2023

Any recent progress on this PR ?

@joeroback
Copy link
Contributor Author

hello. friendly ping. last commit was november 2022, is this project dead / in need of help? PR is almost 2 months old. thanks!

@joeroback
Copy link
Contributor Author

joeroback commented Feb 13, 2023 •
edited
Loading

@hyunsik sorry to be a bother, but anyway to get this PR and new version for this? thanks

@hyunsik
Copy link
Owner

hyunsik commented Feb 24, 2023

@joeroback Hi, I'm very sorry for late. I'll review it tomorrow.

@hyunsik hyunsik self-requested a review February 24, 2023 08:00
hyunsik
hyunsik approved these changes Feb 24, 2023
View reviewed changes
Copy link
Owner

@hyunsik hyunsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks great to me. I'm sorry again for a late review.

@hyunsik hyunsik merged commit eaaf3bc into hyunsik:master Feb 24, 2023
@hyunsik
Copy link
Owner

hyunsik commented Feb 24, 2023 •
edited
Loading

@joeroback I've just released out the new version. Thank you.
https://crates.io/crates/bytesize/1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyunsik hyunsik hyunsik approved these changes

Assignees

@joeroback joeroback

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serde support in human readable?
3 participants
@joeroback @v0y4g3r @hyunsik