Fix form field regression #29
Conversation
|
Now that Travis is back online, he seems to disagree with the tests. Let's see what I can do to fix that... |
akx
force-pushed
the
form-field-regression
branch
2 times, most recently
from
bba3d98
to
c681859
Compare
Seems we're up to 92% now.
akx
force-pushed
the
form-field-regression
branch
from
c681859
to
737f0c8
Compare
akx
force-pushed
the
form-field-regression
branch
from
737f0c8
to
9e57d23
Compare
|
The Django 1.4 configurations still fail due to a missing |
akx
force-pushed
the
form-field-regression
branch
from
9e57d23
to
8388d62
Compare
|
That's more like it! |
|
Brilliant! Thanks so much!! I feel like a jerk for even mentioning this given your awesome contributions, but generally you shouldn't bump versions in PRs. Usually people want to tag the version after the merge commit and, besides, it can make it harder if other PRs/versions get dealt with in the meantime. But seriously, this is great. Thanks! |
|
Haha, yeah, I figured it's a 50/50 chance to either get flak for doing the bump in the PR or for it to be convenient for you :) Won't do it next time! Anyway, you're welcome! |
Well, damnit.
Looks like my fancy patch broke loading enum values from instances from
ModelForms; there wasn't a valid test for it either.Now there's a fix and while at it, I improved test coverage in general.