Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for orientation being swapped as described in https://github.com/hzeller/rpi-rgb-led-matrix/issues/1663 #1664

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

marcmerlin
Copy link
Contributor

No description provided.

This fixes hzeller#1663

TEST=
Tested on both chains of physical 4 and 5 panels, and now the orientation
does not change anymore when I switch from 4 to 5 panels in software.
@marcmerlin
Copy link
Contributor Author

marcmerlin commented Jun 11, 2024

After this fix (ignore the upside down, the important part is orientation remains the same)

--led-chain=4
PXL_20240611_193703235

--led-chain=5 (displays spills out on missing panel but orientation and panel order is preserved)
PXL_20240611_193738126

@marcmerlin
Copy link
Contributor Author

putting the issue in the subject line didn't work, let me reference it here: #1663

@hzeller hzeller merged commit a98c563 into hzeller:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants