Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cors preflight support #139

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Cors preflight support #139

merged 3 commits into from
Apr 13, 2020

Conversation

ckkz-it
Copy link
Contributor

@ckkz-it ckkz-it commented Apr 10, 2020

#97

Copy link
Owner

@hzlmn hzlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for PR. Seems like some problems with GitHub travis ci status update, but could You fix linting error
0.36s$ flake8 --show-source tests tests/test_middleware.py:249:80: E501 line too long (95 > 79 characters) async def test_pass_preflight_options_request(create_app, aiohttp_client, fake_payload, token):
other from these small fixes, everything LGTM.

tests/test_middleware.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   98.13%   98.16%   +0.03%     
==========================================
  Files           4        4              
  Lines         107      109       +2     
==========================================
+ Hits          105      107       +2     
  Misses          2        2              
Impacted Files Coverage Δ
aiohttp_jwt/middleware.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7deb6...431da22. Read the comment docs.

Copy link
Owner

@hzlmn hzlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hzlmn hzlmn merged commit cd749e4 into hzlmn:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants