-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/capture chunks #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I don't think I can really review the Django side of things in any detail.
On tying this up with other changes, this is still worth doing as retaining Chunks in parts of core-api is my plan short term. Replacing all the way through the system would be a scary change and I think we can do it incrementally.
This reverts commit cc1bb0b.
Context
As a User I want the django app to persist the specific text chunk referenced in RAG so that I can know exactly which part of the document has been referenced.
Changes proposed in this pull request
ChatMessage
source_files
toold_source_files
TextChunk
to capture the relationship between theChatMessage
,File
and the specific text used in RAGChatMessage
calledsource_files
that, like the old field, is a m2m field toFiles
but has a through relationship viaTextChunk
old_source_files
tosource_files
old_source_files
in case something goes wrong and or we want to revert this change in productionGuidance to review
Relevant links
Things to check