Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sign in confirmation page. #619

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

brunns
Copy link
Contributor

@brunns brunns commented Jun 20, 2024

Context

A proposed solution for REDBOX-248 - skip the sign-in confirmation page.

Changes proposed in this pull request

Auto-skip the sign-in confirmation page.

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@brunns
Copy link
Contributor Author

brunns commented Jun 20, 2024

I have not yet fixed the integration tests for this change. I will do the before suggesting review if people think it's a good idea.

@KevinEtchells
Copy link
Contributor

LGTM. Any security concerns around this?

@brunns brunns marked this pull request as ready for review June 21, 2024 10:47
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunns brunns merged commit 1ccca60 into main Jun 24, 2024
4 checks passed
@brunns brunns deleted the feature/REDBOX-307-skip-sign-in-confirmation branch June 24, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants