Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send route name to the front end #621

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

rachaelcodes
Copy link
Contributor

Context

Adds the changes proposed in #574 and #588 (which were both closed until other things were merged in the meantime).

Changes proposed in this pull request

  • Adds a ChatRoute class in redbox/models to consolidate route names
  • returns 'route_name' in ChatResponse and in the streaming response
  • tests the above
  • TODO: add to e2e test

Guidance to review

Have I tested enough? Is the ChatRoute Enum actually useful?

Relevant links

https://technologyprogramme.atlassian.net/browse/REDBOX-326

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@gecBurton gecBurton marked this pull request as ready for review June 20, 2024 15:02
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have I tested enough? Is the ChatRoute Enum actually useful?

yes and yes 🎉

@gecBurton gecBurton merged commit ac7ee45 into main Jun 20, 2024
5 checks passed
@gecBurton gecBurton deleted the feature/share-selected-route branch June 20, 2024 15:05
@rachaelcodes rachaelcodes mentioned this pull request Jun 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants