Feature/new design system #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEtchells
force-pushed
the
feature/new-design-system
branch
from
5ffeb34
to
01be7cc
Compare
KevinEtchells
force-pushed
the
feature/new-design-system
branch
from
10efb18
to
cba1779
Compare
KevinEtchells
force-pushed
the
feature/new-design-system
branch
from
54692d6
to
31c0bc5
Compare
KevinEtchells
force-pushed
the
feature/new-design-system
branch
from
ada2e28
to
5525362
Compare
brunns
reviewed
Jun 21, 2024
| def _doc_from_element(element: Locator) -> DocumentRow: | ||
| filename = element.locator(".iai-doc-list__cell--file-name").inner_text() | ||
| status = element.locator("file-status").inner_text() | ||
| return DocumentRow(filename=filename, status=status) |
Add lock file Update tests update tests
KevinEtchells
force-pushed
the
feature/new-design-system
branch
from
5525362
to
24983ef
Compare
brunns
reviewed
Jun 21, 2024
| expires=expires, | ||
| status=status, | ||
| ) | ||
| for filename, uploaded_at, expires, status, action in batched(cell_texts, 5) |
There was a problem hiding this comment.
We probably don't need the batched() function any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Phase 1 of implementing the new i.AI design system.
The actual design system code lives at https://github.com/i-dot-ai/design-system
This PR is marked as a draft at the moment as this will almost certainly break some tests, which will need looking at before it's ready to deploy.
What this is:
What this isn't:
Guidance to review
This could do with a few eyes on it, across all pages, to check the following:
We will definitely be interested in more detailed feedback for future iteration, but keen to just focus on what we need to do to get this baseline version over the line this week.