Add logic within summarisation route to select appropriate stuff or map reduce method #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stuff or map reduce summarisation method based on length of list of strings
…o use the retrieval prompts
…n for basic summarisation and map reduce summarisation for large documents
wpfl-dbt
reviewed
Jun 28, 2024
| return ( | ||
| RunnablePassthrough.assign(documents=(make_document_context | RunnableLambda(format_documents))) | ||
| | make_chat_prompt_from_messages_runnable( | ||
| # Stuff chain now missing the RunnabeLambda to format the chunks |
There was a problem hiding this comment.
This doesn't need to make it into production
| @@ -45,6 +45,7 @@ pytest = "^8.2.2" | |||
| pytest-env = "^1.1.1" | |||
| pytest-mock = "^3.14.0" | |||
| pytest-cov = "^5.0.0" | |||
| pytest-dotenv = "^0.5.2" | |||
There was a problem hiding this comment.
We already use pytest-env and tbh I strongly prefer it, but if we're going this way we should remove it. No one actually uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a user wants to summarise a document, they are not concerned with the method that is used to do the summarisation. Under-the-hood, however, when going down the summarisation route
core-apineeds to select the appropriate method,stufffor basic summarisation ormap reducefor large document summarisation.Changes proposed in this pull request
Reduced summarisation runnable to a single
build_summary_chainthat uses logic within the langchain runnable to decide which summarisation method to use, based on the size of the document, set bysummarisation_chunk_max_tokens.core-apinow passes back to the frontend which summarisation method was used.Guidance to review
Relevant links
Things to check