Do not show link to deleted files. #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <a class="iai-chat-bubbles__sources-link govuk-link" href="{{ source.url }}">{{ source.original_file_name }}</a> | ||
| {% else %} | ||
| <p class="iai-chat-bubbles__sources-link">{{ source.original_file_name }}</p> |
There was a problem hiding this comment.
Please can you make this a <span> rather than a <p>?
That will keep the vertical spacing consistent when there are multiple links, and I don't think it needs the paragraph semantic meaning.
Co-authored-by: Kevin Etchells <kevin.etchells@cabinetoffice.gov.uk>
KevinEtchells
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Where an existing chat references a source file which ha since been deleted, there will be no file to link to.
We'd still like to show the file name for context with the response.
Changes proposed in this pull request
Relevant links
Things to check