Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3-lock vs compton: Desktop displaying/flickering over #130

Closed
JulienDlq opened this issue Jun 7, 2017 · 11 comments · Fixed by #133
Closed

i3-lock vs compton: Desktop displaying/flickering over #130

JulienDlq opened this issue Jun 7, 2017 · 11 comments · Fixed by #133
Labels

Comments

@JulienDlq
Copy link

Hi!

I was using i3-lock 2.8 on Gentoo with compton 0.1_beta2 for months, and everything was beautiful.

But I recently updated i3lock to 2.9 and now the content of my desktop is displaying/flickering over i3-lock…
i3-lock is still reachable and password can be typed and session can be unlocked.

Is it possibly linked to #96 ?

@Airblader Airblader added the bug label Jun 8, 2017
@Airblader
Copy link
Member

Is it possibly linked to #96 ?

Almost definitely, yes. CC @sandsmark.

Note that i3lock does not support compositing, neither before nor after that PR. So reverting #96 is definitely an option to consider.

@hellbound22
Copy link

Same thing with Arch Linux. I use "xcompmgr -c -f -n" Worked fine until a full update

@lisuml
Copy link

lisuml commented Jun 12, 2017

Any chance for getting it fixed or the only solutions are to disable compositing or stay at 2.8?

@Airblader
Copy link
Member

Any chance for getting it fixed

Sure; find the root cause and a solution and we can discuss it over a PR. As long as no one works on this the situation won't change unless we revert #96 for 2.10.

I think I'm currently leaning towards a revert because it affects multiple users and #96 was about improvements for compositing which we don't support anyway, so with no one stepping up to make this work a revert would be the easy solution.

@sandsmark
Copy link
Contributor

Compositing is a mess, and I'm not in mood to go digging through the code of various compositors to figure out what they're doing wrong, so I guess reverting is the best solution.

@Airblader
Copy link
Member

@JulienDlq / @PhdTrollSlayer / @lisuml

Can either one of you confirm that reverting #96 fixes the issue?

@lisuml
Copy link

lisuml commented Jun 19, 2017

@Airblader: Yes, confirmed. After reverting #96 version 2.9 works as expected with compton on Arch Linux.

@sandsmark
Copy link
Contributor

fwiw, just tested with an nvidia driver and compton.

with the revert i3bar is sometimes shown while locked, and the desktop is sometimes shown when locked (e. g. when resuming from suspend). without the revert, the desktop is never shown again after unlocking (until I switch to another tty and back again).

conclusion: compositing sucks.

@bebehei
Copy link

bebehei commented Nov 10, 2018

Hey guys, I don't think this is fixed. I can easily reproduce it on a vanilla Ubuntu 18.04 install.

$> sudo apt install i3-wm i3lock i3status dunst compton

# And after i3 login:
$> compton -c &
$> dunst &
$> (sleep 7 && notify-send a b) &
$> i3lock

screenshot-bionic

If I read this issue right, this should have been fixed in 2.10, right? But Ubuntu 18.04 covers i3lock 2.10 and it doesn't seem to be fixed.

$> i3lock --version
i3lock: version 2.10 (2017-11-25) © 2010 Michael Stapelberg

@stapelberg
Copy link
Member

This issue is about the undesired side-effects of the fix for what you’re seeing, not about the issue itself.

Can you open a new issue for that please?

A workaround is to send SIGUSR1 to dunst before invoking i3lock. See https://manpages.debian.org/stretch/dunst/dunst.1.en.html#MISCELLANEOUS

@bebehei
Copy link

bebehei commented Nov 10, 2018

This issue is about the undesired side-effects of the fix for what you’re seeing, not about the issue itself.

Oh ok. Thanks. I opened a new issue about it.

A workaround is to send SIGUSR1 to dunst before invoking i3lock. See https://manpages.debian.org/stretch/dunst/dunst.1.en.html#MISCELLANEOUS

Well, I'm a maintainer of dunst and I honestly cannot recommend this! There's no way to check the status of dunst. We're trying to implement a proper client for this.

Hedroed pushed a commit to Hedroed/i3lock that referenced this issue Nov 23, 2021
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 16, 2024
2022-06-21 i3lock 2.14.1

 • unlock indicator: display only caps lock and num lock,
   not all modifiers like shift (which can leak information
   about your password to bystanders)

2022-05-28 i3lock 2.14

 • Change default background color to #a3a3a3
   See i3/i3lock#300 for extensive
   discussion and rationale for this change.
 • Recommend using xss-lock to start i3lock in the README
   and i3lock.1 man page. xss-lock is the best way to ensure
   your screen truly is locked before your computer suspends.
 • Display modifier key warning before unlocking, too,
   not just on failed attempts like before.
 • Switch build system from autotools to meson.

2020-10-27 i3lock 2.13

 • Throw error when trying to start on Wayland
 • Use explicit_bzero() where available, not just on OpenBSD
 • avoid pixmap allocations in the redraw path
 • make --debug output go to stderr
 • unlock_indicator.c: fix build failure against gcc-10
 • fix: call pam_end in cleanup in main, not in event loop
 • set _NET_WM_BYPASS_COMPOSITOR hint to avoid flickering

2019-07-21 i3lock 2.12

 • remove stray \n from error messages
 • capitalize unlock indicator contents
 • set WM_CLASS property
 • reference modifier as “Super”, not “Win”
 • add --raw option to read image as raw bytes

2018-10-18 i3lock 2.11.1

 • Fix dist tarball by including I3LOCK_VERSION

2018-10-10 i3lock 2.11

 • Switch to autotools
 • Display an error when backspace is pressed without any input
 • Print an error when a non-PNG file is opened
   (i3lock only supports PNG files) (Thanks eplanet)
 • Don’t unnecessarily check the xcb_connect return value,
   it is known never to be NULL (Thanks SegFault42)
 • Fix memory leak when grabbing fails (Thanks karulont)
 • Respect Xft.dpi for determining the unlock indicator’s scale factor
 • Discard pending password verification attempts
   when a new password is entered (Thanks layus)

2017-11-25 i3lock 2.10

 • Only use -lpam when not on OpenBSD (Thanks Kaashif)
 • locale: treat empty string same as unset (Thanks Ran)
 • Fix overwrite of getopt optind (Thanks jakob)
 • Immediately hide the unlock indicator after ESC / C-u (Thanks Orestis)
 • Measure wall-clock time instead of CPU time for “locking” indicator.
 • SetInputFocus to the i3lock window to force-close context menus
 • Use RandR for learning about attached monitors

2017-06-21 i3lock 2.9.1

 • Fix version number mechanism (for --version)
 • Revert the fix for composited notifications, as it causes more issues than
   it solves:
   i3/i3lock#130
   i3/i3lock#128

2017-05-26 i3lock 2.9

 • i3lock.1: use signal names without SIG prefix
 • Removed obsolete inactivity timeout
 • Added version files for release tarball.
 • Set font face
 • Automatically unlock (without having to press <Enter>) one attempt which was
   entered while authenticating
 • Stop leaking the image_path dup
 • Displaying locking message when grabbing the pointer/keyboard
 • Display error message when locking failed
 • Add Enter on C-m
 • Change input slices to be exactly pi/3 in size instead of slightly more
 • Fix covering of composited notifications using the XComposite extension
 • Remove last traces of DPMS
 • Use bsd_auth(3) instead of PAM on OpenBSD
 • Restore intended behaviour and don't use mlock(2) on OpenBSD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants