Added a few functionalities to stx_science_data_lightcurve #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grazwegian
suggested changes
Jul 20, 2022
| @@ -23,16 +23,21 @@ | |||
| ; | |||
| ; time_min : in, type="float", default="20." | |||
| ; Minimum time size in seconds | |||
| ; | |||
| ; time_shift : in, type="string", default: taken from the FITS header | |||
There was a problem hiding this comment.
Usually I would have time_shift as a float.
There was a problem hiding this comment.
Of course, apologize for the mistake :)
| @@ -44,24 +49,44 @@ | |||
| ; | |||
| ; :history: | |||
| ; 30-Jun-2022 - ECMD (Graz), initial release | |||
| ; 15-Jul-2022 - Andrea Francesco Battaglia (FHNW) | |||
| ; Added a few functionalities: | |||
| ; -> automatic recognition of SPEC and CPD files: /is_pixel_data is no more needed | |||
There was a problem hiding this comment.
Suggested change
| ; -> automatic recognition of SPEC and CPD files: /is_pixel_data is no more needed | |
| ; -> automatic recognition of SPEC and CPD files: /is_pixel_data is no longer needed |
There was a problem hiding this comment.
Slight change of wording
Comment on lines
88
to
90
| endif else begin | ||
| message, 'ERROR: the FILENAME field in the primary header should contain either cpd or spec' | ||
| endelse |
There was a problem hiding this comment.
I think this won't work with the L1A files which have a different naming scheme? In the short term it would be good to be able to use them too.
There was a problem hiding this comment.
Ok, I will create a new pull request allowing the alpha version files too.
grazwegian
approved these changes
Jul 21, 2022
grazwegian
approved these changes
Jul 25, 2022
samaloney
approved these changes
Aug 4, 2022
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Aug 8, 2022
…dates * commit 'bc3ecfceee3785d0b07261df4f82b1a1a4e468f0': Fix error in sci energy channel config file (i4Ds#96) Added automatic check for energy shift (i4Ds#101) Added a few functionalities to stx_science_data_lightcurve (i4Ds#99) # Conflicts: # stix/idl/processing/spectrogram/stx_convert_pixel_data.pro # stix/idl/processing/spectrogram/stx_convert_spectrogram.pro
grazwegian
added a commit
to grazwegian/STIX-GSW
that referenced
this pull request
Aug 8, 2022
* automatic-fitting: Pass through additional useful keywords to the spectrum and srm FITS files Fix error in sci energy channel config file (i4Ds#96) Added automatic check for energy shift (i4Ds#101) Added a few functionalities to stx_science_data_lightcurve (i4Ds#99) stx_read_elut - fixed issue when filename keyword is not used # Conflicts: # stix/idl/processing/spectrogram/stx_convert_pixel_data.pro # stix/idl/processing/spectrogram/stx_convert_science_data2ospex.pro # stix/idl/processing/spectrogram/stx_convert_spectrogram.pro # stix/idl/processing/spectrogram/stx_fsw_sd_spectrogram2ospex.pro # stix/idl/processing/spectrogram/stx_write_ospex_fits.pro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed with @grazwegian, I have added the following functionalities to the stx_science_data_lightcurve procedure:
Best,
Andrea