Fixed issue with unrecognized bindings. Needed to work with SAMLTest.id #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.ID's metadata (https://samltest.id/saml/sp) which includes a Shibboleth binding definition before the supported binding types.
i8beef
reviewed
May 15, 2020
|
No warnings about not using brackets; I use that syntax all of the time for one-liner validation/consistency checks. It's just a stylistic choice. |
|
Its a stylistic choice that is forbidden by StyleCop rules in this project though, and which you will see as warnings in the build, like so: https://ci.appveyor.com/project/i8beef/saml2/builds/32902619#L44 Thank you for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAMLTest.ID's metadata (https://samltest.id/saml/sp) includes a Shibboleth binding definition before the supported binding types. That was causing a "Binding not supported" exception to be thrown. My change ignores unsupported bindings, but will throw an exception if no supported bindings are found.