Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gypcrete-build] Upgrade webpack to v3 #101

Merged
merged 3 commits into from
Oct 24, 2017
Merged

[gypcrete-build] Upgrade webpack to v3 #101

merged 3 commits into from
Oct 24, 2017

Conversation

cjies
Copy link
Contributor

@cjies cjies commented Oct 24, 2017

Implement

Update the webpack dependency in main package to v3, also upgrade related plugins and loaders.

No breaking changes.

@cjies cjies requested a review from zhusee2 October 24, 2017 03:29
zhusee2
zhusee2 approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@cjies cjies merged commit f92c07e into develop Oct 24, 2017
@cjies cjies deleted the CJ/webpack_v3 branch October 24, 2017 03:38
@cjies
Copy link
Contributor Author

cjies commented Oct 24, 2017

Done 2nd todo of #81

@zhusee2 zhusee2 mentioned this pull request Oct 26, 2017
Merged
@cjies cjies mentioned this pull request Oct 31, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhusee2 zhusee2 zhusee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjies @zhusee2