Migrate <Button> #14
Merged
Migrate <Button> #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing everything unknown to their underlying <div>s
cjies
suggested changes
Mar 30, 2017
src/Button.js
Outdated
| const BLACK = 'black'; | ||
| export const BUTTON_COLOR = { BLUE, RED, WHITE, BLACK }; | ||
|
|
||
| function Button(props) { |
There was a problem hiding this comment.
Direct extract props from param?
function Button({ color, solid, className, children, ...buttonProps }) {
// ...
}
cjies
reviewed
Mar 30, 2017
|
|
||
| Button.propTypes = { | ||
| color: PropTypes.oneOf(Object.values(BUTTON_COLOR)), | ||
| solid: PropTypes.bool, |
There was a problem hiding this comment.
It's now recommended in Airbnb style guide, because it can make git diffs cleaner
https://github.com/airbnb/javascript#commas--dangling
cjies
reviewed
Mar 30, 2017
|
|
||
| Button.defaultProps = { | ||
| color: BLUE, | ||
| solid: false, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bring back
<Button>from ic-framework-react.Note this does not contain the icon-only variant, as I plan to split it to an independent component.
Implement
<Button>which supportscolorandsolidmodifiersrowComp()is refactored to set default props of<RowComp><Tag>now inherits color from parent nodes.Demo