Display error message of <IconLayout> on a <Tooltip> #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjies
suggested changes
Apr 10, 2017
| ReactDOM.render(element, div); | ||
| }); | ||
|
|
||
| it('renders on top of anchor when possible or needed', () => { |
There was a problem hiding this comment.
這 description 應該需要清楚解釋說在 700px 的位置(熒幕下方)的時候，即使是 <AnchoredBoxTop> 或 <AnchoredBoxBottom> 都會出現 top anchor。
maybe like renders top anchor when placed at the bottom of screen?
cjies
reviewed
Apr 10, 2017
| const layerId = wrapper.instance().baseLayer.id; | ||
|
|
||
| // Make sure the layer is created | ||
| expect(document.getElementById(layerId)).not.toBeNull(); |
There was a problem hiding this comment.
expect(document.getElementById(layerId)).toBeTruthy();
感覺沒這麼拗口？ XD
There was a problem hiding this comment.
但我覺得 toBeTruthy() 的意思就是拿來測 Boolean XD
雖然這樣會動，但我覺得意思不對
|
others LGTM 辛苦了 💦 |
cjies
approved these changes
Apr 17, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The error message for an
<IconLayout>should be displayed on a<Tooltip>which shows up on hover, according to the design spec.Implement
<Tooltip>outside components which hide overflow contents, the following are migrated:anchored()mixin (determines absolute position)renderToLayer()mixin (renders Component outside of React root)<AnchoredTooltip>(simplified version)