Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 and Jest 23.6.0 #185

Merged
merged 11 commits into from
Nov 6, 2018
Merged

Upgrade to Babel 7 and Jest 23.6.0 #185

merged 11 commits into from
Nov 6, 2018

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Nov 5, 2018

Purpose

Upgrade to Babel 7 so it supports future React 16 new syntaxes.

Changes

  • [Build] Upgrade to Babel v7; switch to project-scope Babel config.
  • [Build] Upgrade to jest@23.6.0 to support Babel 7.
  • [Core] [Form] [ImageEditor] Switch peer dependency from babel-runtime to @babel/runtime-corejs2.

Node: 8.2.1 (lts/carbon)
npm: 5.10 (lts)
Yarn: 1.10 (introduces package integrity)
@zhusee2 zhusee2 added this to the Version 2 milestone Nov 5, 2018
@zhusee2 zhusee2 self-assigned this Nov 5, 2018
@zhusee2 zhusee2 requested a review from hsunpei November 5, 2018 10:42
Copy link
Contributor

@hsunpei hsunpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade 👍 🚢

@zhusee2 zhusee2 merged commit 1ecfcc8 into develop Nov 6, 2018
@zhusee2 zhusee2 deleted the feature/upgrade_babel branch November 6, 2018 06:37
@cjies cjies mentioned this pull request Nov 6, 2018
8 tasks
@zhusee2 zhusee2 mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants