Feature/zhusee editable text #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content Also tweaks to prevent Terminal console being flooded by chunk modules. However the settings will not be taken into middleware config at this version of Storybook (2.35.3) It's expected to be effective on next relase of Storybook.
zhusee2
force-pushed
the
feature/zhusee_editable_text
branch
from
57ed92d
to
4b1d521
Compare
cjies
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a
<Text>element with an<input>inside.This visual element is supposed to be used within
<TextInput>.Implement
<EditableText>is a special version of<Text>, which places an<input>absolutely above the basic row. The<input>stays transparent until it gets focused.<div>instead of<input>, because the border should be placed below the basic row and thus will be hidden byoverflow: hiddenrule.<input>is focused, itself will be visible while the basic text under it will be hidden. Because the basic text and the<input>should look the same, the only difference on screen should be only the border line.<Text>to prevent distraction in edit mode.Demo