Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] add "upload" icon #410

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[Icon] add "upload" icon #410

merged 2 commits into from
Sep 15, 2023

Conversation

leannechen
Copy link
Contributor

@leannechen leannechen commented Sep 14, 2023 •
edited
Loading

Purpose

新增「upload」icon
CleanShot 2023-09-14 at 15 37 01

Changes

  • a list of what have been done
  • maybe some code change

Risk

Usually none, if you have any please write it here.

TODOs

  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

@github-actions github-actions bot temporarily deployed to canary September 14, 2023 07:30 Inactive
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #410 (31ce525) into develop (011922d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #410      +/-   ##
===========================================
+ Coverage    88.45%   88.47%   +0.01%     
===========================================
  Files          151      152       +1     
  Lines         1542     1544       +2     
  Branches       283      283              
===========================================
+ Hits          1364     1366       +2     
  Misses         178      178
Files Changed Coverage Δ
packages/core/src/icons/components/Upload.js 100.00% <100.00%> (ø)

@leannechen leannechen changed the title feat: add 'upload' icon [Icon] add 'upload' icon Sep 14, 2023
@leannechen leannechen self-assigned this Sep 14, 2023
@leannechen leannechen marked this pull request as ready for review September 14, 2023 07:38
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot temporarily deployed to canary September 14, 2023 07:50 Inactive
@leannechen leannechen changed the title [Icon] add 'upload' icon [Icon] add "upload" icon Sep 14, 2023
@leannechen leannechen merged commit 0682517 into develop Sep 15, 2023
10 checks passed
@leannechen leannechen deleted the feature/add_upload_icon branch September 15, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orcus2021 Orcus2021 Orcus2021 approved these changes

@chenesan chenesan chenesan approved these changes

Assignees

@leannechen leannechen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leannechen @chenesan @Orcus2021