test: add testing-library #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## docs/upgrade-storybook-v6-with-webpack5 #415 +/- ##
===========================================================================
+ Coverage 88.47% 98.06% +9.59%
===========================================================================
Files 152 69 -83
Lines 1544 1450 -94
Branches 283 287 +4
===========================================================================
+ Hits 1366 1422 +56
+ Misses 178 28 -150 |
chenesan
approved these changes
Dec 13, 2023
|
@chenesan 後來也更新了 jest 和重寫 SearchInput 的測試，再請你 review 一下 🙇🏼 |
chenesan
approved these changes
Dec 14, 2023
|
Base automatically changed from
docs/upgrade-storybook-v6-with-webpack5
to
project/upgrade-react-v18
December 18, 2023 10:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
SearchInputwith testing-library since the original one is not working after upgrading jest.