Add <EditableTextLabel> #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhusee2
force-pushed
the
feature/zhusee_editable_text_label
branch
2 times, most recently
from
92a6152
to
eb80f15
Compare
cjies
reviewed
May 23, 2017
src/EditableText.js
Outdated
| value: event.target.value, | ||
| }); | ||
| this.setState( | ||
| { lastNotified: Date.now() }, |
There was a problem hiding this comment.
why not use currentTimestamp as value?
There was a problem hiding this comment.
because I forgot to XD
since that will be removed when passing through Babel under production mode
zhusee2
force-pushed
the
feature/zhusee_editable_text_label
branch
from
ac40c02
to
809c406
Compare
|
Fixed and rebased with latest |
<WithStatus> still needs to re-render when context changes. That way it must be a React Component instead of a PureComponent
…rom firing 2 notifications
zhusee2
force-pushed
the
feature/zhusee_editable_text_label
branch
from
809c406
to
88ff438
Compare
cjies
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
<EditableTextLabel>which can go into edit mode by turning oninEditprop.It also calls
onEditRequestcallback when double-clicked on desktop browsers, so you know when to set theinEditprop.Implement
<EditableText>now takes anonEditEndcallback, and will call that on:<Input>blur. (call as save)Enterkey . (call as save)Esckey. (call as reset/cancel)Add
<EditableTextLabel>to be used when you know this text label should carry editing logics. If you're sure a text label is not supposed to be edited, use<TextLabel>.Demo