Multi-lines <textarea> input #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjies
approved these changes
Jul 4, 2017
zhusee2
force-pushed
the
feature/zhusee_refactor_editable
branch
from
cfaf2d6
to
cc0ed06
Compare
zhusee2
force-pushed
the
feature/zhusee_textarea
branch
from
3f72329
to
8c4c657
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Supports inputs in multiple lines
Implement
inputTagprop to<EditableBasicRow>so it can beinput(for single-line) ortextarea(for multiple lines).white-space: pre-wrapto the basic label in<EditableBasicRow>to correctly display line-breaks and white-spaces from<textarea>. This also ensures the<textarea>can grow automatically when you add more lines.Dependency
#63 Refactor editable components
Demo