-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Lerna mono-repo architecture #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Babel uses that too)
This includes: - babel-plugin-module-resolver --> 3.0.0-beta.5 - eslint-import-resolver-babel-module --> 4.0.0-beta.3
@cjies Please help review the |
zhusee2
force-pushed
the
feature/zhusee_learna
branch
from
October 11, 2017 09:40
c0233ab
to
4d750d8
Compare
… prepare built files
cjies
reviewed
Oct 11, 2017
- "if [ ${TRAVIS_PULL_REQUEST} = 'false' ]; then yarn deploy; fi" | ||
# Publish storybook to gh-pages branch | ||
- "if [ ${TRAVIS_PULL_REQUEST} = 'false' ] && [ ${TRAVIS_BRANCH} = 'master' ]; then yarn ghpages; fi" | ||
# Publish canary builds when feature merges back to develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@zhusee2 Yes sure, publish the alpha releases to npm is the better approach. 👍 |
cjies
approved these changes
Oct 11, 2017
可惡手殘按到 update branch XDDD |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To make Gypcrete a multi-packages mono-repo so it can add more packages in the future.
This PR converts the original Gypcrete repo into 2 packages:
@ichef/gypcrete
.)gp-pages
branch of this repo.)The source codes for components and stories are not changed, so it should not affect existing packages.
The
dist
branch will no longer receiving builds in the future. Instead we'll publish canary builds to NPM usinglerna publish --canary
script.Please refer to
CHANGELOG
andREADME
for more details.