Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Lerna mono-repo architecture #87

Merged
merged 23 commits into from
Oct 12, 2017
Merged

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Oct 11, 2017

Purpose

To make Gypcrete a multi-packages mono-repo so it can add more packages in the future.

This PR converts the original Gypcrete repo into 2 packages:

  • core package (publishes to @ichef/gypcrete.)
  • storybook package (publishes to gp-pages branch of this repo.)

The source codes for components and stories are not changed, so it should not affect existing packages.

The dist branch will no longer receiving builds in the future. Instead we'll publish canary builds to NPM using lerna publish --canary script.

Please refer to CHANGELOG and README for more details.

@zhusee2 zhusee2 requested a review from cjies October 11, 2017 08:34
@zhusee2
Copy link
Contributor Author

zhusee2 commented Oct 11, 2017

@cjies Please help review the .travis.yml file. It looks like we might receive duplicated canary releases when codes are merged from master --> develop. What do you think?

- "if [ ${TRAVIS_PULL_REQUEST} = 'false' ]; then yarn deploy; fi"
# Publish storybook to gh-pages branch
- "if [ ${TRAVIS_PULL_REQUEST} = 'false' ] && [ ${TRAVIS_BRANCH} = 'master' ]; then yarn ghpages; fi"
# Publish canary builds when feature merges back to develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjies
Copy link
Contributor

cjies commented Oct 11, 2017

@zhusee2 Yes sure, publish the alpha releases to npm is the better approach. 👍

@zhusee2
Copy link
Contributor Author

zhusee2 commented Oct 12, 2017

可惡手殘按到 update branch XDDD

@zhusee2 zhusee2 merged commit 03a1157 into develop Oct 12, 2017
@zhusee2 zhusee2 deleted the feature/zhusee_learna branch October 12, 2017 03:59
@zhusee2 zhusee2 mentioned this pull request Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants