[Storybook] Addon API changes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets webpack can resolve the modules in storybook/ package.
Refactor to `withPropsTable()` HOF to avoid the overwrite of `.add()` in the future. storybookjs/storybook#1147
Addon injection is deprecated and slate for removal in v4.0, use the `withInfo()()()` currying function to replace `addWithInfo` API.
|
Let's split the todo to another issue, and merge this early. |
zhusee2
approved these changes
Oct 16, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The info addon have some API changes,
.addWithInfo()will be deprecated soon and changed towithInfo()HOF.Why it changed?
Avoid to overwrite origin
.add()API, and the.addWithXXX()pattern is just allow one addon per story. In the newwithX()primitives, we can compose multiple addons in a story.Links:
storybook migration guide
storybookjs/storybook#1147 (comment)
Implement
<DebugBox>and<FlexRow>to utils/ folder.withPropsTable()HOF to avoid overwriting.add()API. (Moveaddon-infointo addons panel storybookjs/storybook#1147).addWithInfo()API to.add('xxx', withInfo('info')(<component>)).