Bugfix: should_assign_to with false passes if that variable has anoth…

…er value

lib/shoulda/action_controller/matchers/assign_to_matcher.rb

@@ -80,7 +80,7 @@ def kind_of_expected_class?
         end
 
         def equal_to_expected_value?
-          return true unless @expected_value
+          return true if @expected_value.nil?
           if @expected_value == assigned_value
             @negative_failure_message =
               "Didn't expect action to assign #{@expected_value.inspect} " <<

test/functional/posts_controller_test.rb

@@ -89,6 +89,9 @@ def setup
       should_fail do
         should_set_the_flash_to /.*/
       end
+      should_fail do
+        should_assign_to(:post) { false}
+      end
     end
 
     context "on GET to #new" do

test/matchers/controller/assign_to_matcher_test.rb

@@ -30,6 +30,9 @@ class AssignToMatcherTest < ActionController::TestCase # :nodoc:
     should "reject assigning to another variable" do
       assert_rejects assign_to(:other), @controller
     end
-  end
 
+    should "reject assigning to that variable with false" do
+      assert_rejects assign_to(:var).with(false), @controller
+    end
+  end
 end