Move Icon Creation to GenerateIssuerIconAssets.sh #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that's super cool! Thanks so much for working on this! I'll read through the script and post feedback inline. |
calleluks
reviewed
Jan 21, 2021
calleluks
reviewed
Jan 21, 2021
calleluks
reviewed
Jan 21, 2021
|
I have a branch locally with quite a few icons without rounded corners and code to round them at runtime. Will post a PR with it as soon as I've had time to clean it up somewhat! |
The inital cp has been replace by sips --resampleWidth 192, and the subsequent usages of sips now all use the source file as their base.
ThinkChaos
reviewed
Jan 21, 2021
|
Alright, all suggestions implemented. Thanks to @ThinkChaos for the RegEx and directory pointers. Probably should squash before merging. |
|
Merged as d6b4544 and 174fcf5 with some small modifications:
Thanks so much @FIGBERT and @ThinkChaos! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After our discussion on #52, I spent some time implementing the automated icon generation we discussed. The
bashscript usessips– which ships with macOS – andag– anackalternative that you can install with Homebrew – to generate the icon files.The one missing feature that we discussed is removing the hard-coded rounded corners, but that can be implemented in another pull request.