Convert to jest #34
Merged
Convert to jest #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ehoogerbeets
commented
Jan 31, 2024
•
ehoogerbeets
commented
- Converted all unit tests from nodeunit to jest
- Use ESM syntax in all the source files
- Fixed a few bugs that turned up because jest ran more of the tests than nodeunit did! (this was due to the conflict in the test names in nodeunit, and jest doesn't have that problem.)
- Added new tests for the static methods of ilib classes that can be called synchronous or asynchronously. Previously, there were no tests for synchronous call mode, only the asynchronous mode.
|
@gouniLee Ready for review now |
gouniLee
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.