Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for FRENCH translation for Precise Similar Topics extension #6

Merged
merged 4 commits into from
Jan 22, 2015

Conversation

Galixte
Copy link
Contributor

@Galixte Galixte commented Dec 26, 2014

Update for FRENCH translation for acp_similar_topics.php
Update for FRENCH translation for info_acp_similar_topics.php
Update for FRENCH translation for permissions_similar_topics.php

Update for FRENCH translation for acp_similar_topics.php
Update for FRENCH translation for info_acp_similar_topics.php
Update for FRENCH translation for permissions_similar_topics.php
@iMattPro
Copy link
Owner

iMattPro commented Jan 4, 2015

Why so many (s) ?? The original English version does not do that.

@Galixte
Copy link
Contributor Author

Galixte commented Jan 22, 2015

Hi,

sorry for my late. In French, and for this part :

+   'PST_YEARS'         => 'Année(s)',
    'PST_MONTHS'        => 'Mois',
-   'PST_WEEKS'         => 'Semaines',
-   'PST_DAYS'          => 'Jours',
+   'PST_WEEKS'         => 'Semaine(s)',
+   'PST_DAYS'          => 'Jour(s)',

When you select many years, like 2 years in French we say : "2 années", but if you choose 1 year we say : "1 année". I have indicated the "(s)" for situations where the user selected more one year, for example. It the same situation for days, weeks, etc ...

Note : Months in French : "Mois" is invariable.

@iMattPro
Copy link
Owner

I get that situation, but you are doing this in a lot of other spots too , like Nombre de sujet(s) similaire(s) à afficher, and this is not something done in any of the other language files or the original english file. I prefer the translations be truer to the original english version.

Update for FRENCH translation for acp_similar_topics.php file
@Galixte
Copy link
Contributor Author

Galixte commented Jan 22, 2015

OK, i have changed for your request : Galixte@e900adb

iMattPro added a commit that referenced this pull request Jan 22, 2015
Update for FRENCH translation for Precise Similar Topics extension
@iMattPro iMattPro merged commit 6a6e3ac into iMattPro:master Jan 22, 2015
@Galixte
Copy link
Contributor Author

Galixte commented Jan 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants