RFC: support PKCE #470
Closed
RFC: support PKCE #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have mentioned that this requires the most recent django-allauth from git, what's available from pypi isn't new enough. |
|
Thank you for taking the time to consider this change. Please. see https://github.com/iMerica/dj-rest-auth/blob/master/README.md#a-note-on-django-allauth-from-imerica |
|
@iMerica I read through your Readme notes and I still don't quite understand the rejection reason for this request. This was a rejection of a security improvement which is part of the Oauth standard and not an allauth specific feature. |
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-allauth has implemented support for PKCE. This RFC PR adds the necessary code_verifier field to the serializer. I've tested it with Google, but I'd like feedback on whether this is something you'd consider merging before I spend more time on it.