Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants for all strings #126

Merged
merged 11 commits into from
Jul 9, 2020
Merged

Add constants for all strings #126

merged 11 commits into from
Jul 9, 2020

Conversation

vlebourl
Copy link
Collaborator

@vlebourl vlebourl commented Jul 7, 2020 •
edited
Loading

Related Github issues: #110

@vlebourl
[refactor] Add constants for all strings
e4e1218 
Related Github issues: #110

Signed-off-by: vlebourl <vlebourl@gmail.com>
@vlebourl vlebourl added the enhancement New feature or request label Jul 7, 2020
@vlebourl
[refactor] Remove unused imports.
a25039c 
Related Github issues: #110

Signed-off-by: vlebourl <vlebourl@gmail.com>
@vlebourl
Copy link
Collaborator Author

vlebourl commented Jul 7, 2020

any idea why that validation is failing?

@vlebourl
Copy link
Collaborator Author

vlebourl commented Jul 7, 2020

i've run it on a couple of merged PR where it was successful, it fails as well. It looks like a bug on their side...

@iMicknl
Copy link
Owner

iMicknl commented Jul 7, 2020 •
edited
Loading

any idea why that validation is failing?

The error is ModuleNotFoundError: No module named 'voluptuous' in HACS validation, however I am not sure why this fails.

It also fails on other PR's, so not sure if I broke something or that he HACS linting has issues.

iMicknl
iMicknl requested changes Jul 7, 2020
View reviewed changes
custom_components/tahoma/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/tahoma/const.py Outdated Show resolved Hide resolved
custom_components/tahoma/light.py Outdated Show resolved Hide resolved
custom_components/tahoma/lock.py Outdated Show resolved Hide resolved
custom_components/tahoma/binary_sensor.py Outdated Show resolved Hide resolved
iMicknl
iMicknl approved these changes Jul 9, 2020
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix the conflicts ;-)

@vlebourl
Copy link
Collaborator Author

vlebourl commented Jul 9, 2020

That was all because of #128...

@vlebourl vlebourl merged commit ec60405 into master Jul 9, 2020
@vlebourl vlebourl deleted the fix_110_2 branch July 9, 2020 08:35
@vlebourl vlebourl mentioned this pull request Jul 10, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetienne tetienne tetienne approved these changes

@iMicknl iMicknl iMicknl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlebourl @iMicknl @tetienne