Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all private properties #145

Merged
merged 11 commits into from
Jul 14, 2020
Merged

Remove all private properties #145

merged 11 commits into from
Jul 14, 2020

Conversation

tetienne
Copy link
Collaborator

No description provided.

@tetienne tetienne changed the title Enhancement/remove all private properties Remove all private properties Jul 11, 2020
@tetienne tetienne force-pushed the enhancement/remove_all_private_properties branch from 1b699f0 to a5a8f32 Compare July 11, 2020 07:17
iMicknl
iMicknl requested changes Jul 11, 2020
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can directly remove the unneeded methods as well, as part of this PR.

custom_components/tahoma/lock.py Outdated Show resolved Hide resolved
custom_components/tahoma/lock.py Outdated Show resolved Hide resolved
custom_components/tahoma/lock.py Outdated Show resolved Hide resolved
custom_components/tahoma/binary_sensor.py Show resolved Hide resolved
vlebourl
vlebourl reviewed Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@vlebourl vlebourl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I won't have the time to review it before Tuesday... Feel free to merge it without my review of it's fine with Mick

@tetienne
Copy link
Collaborator Author

I still have to clean the climate platform. I keep it for the end...

@tetienne tetienne force-pushed the enhancement/remove_all_private_properties branch from 47f52a1 to 88738d6 Compare July 12, 2020 21:57
@tetienne tetienne force-pushed the enhancement/remove_all_private_properties branch from 88738d6 to 8a41caa Compare July 12, 2020 22:09
@tetienne tetienne force-pushed the enhancement/remove_all_private_properties branch from 8a41caa to a6fcf50 Compare July 12, 2020 22:27
@tetienne tetienne requested a review from iMicknl July 12, 2020 22:30
@tetienne tetienne marked this pull request as ready for review July 12, 2020 22:30
@tetienne
Copy link
Collaborator Author

Climate is really too complex, I've only remove some unused variables.

@tetienne
Copy link
Collaborator Author

Ready to be merged.

@vlebourl
Copy link
Collaborator

Climate is really too complex, I've only remove some unused variables.

I wrote that! It was tough to be honeset. I'll have a look later this week.

@tetienne tetienne merged commit c6efc4c into master Jul 14, 2020
@tetienne tetienne deleted the enhancement/remove_all_private_properties branch July 14, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlebourl vlebourl vlebourl approved these changes

@iMicknl iMicknl iMicknl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetienne @vlebourl @iMicknl