Remove return from apply_action
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
added a commit
that referenced
this pull request
Jul 20, 2020
commit 997ccb0 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Mon Jul 20 09:41:08 2020 +0200 Fix rescheduling update. (#158) * Fix rescheduling update. Replacing `self.schedule_update_ha_state(True)` by `self.hass.add_job(self.update)` actually does reschedule the update in a non blocking way. Adding `self.schedule_update_ha_state()` at the end tells HA to write down the newly polled state. * Add throttle to prevent too many calls. commit db7e26c Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 21:59:38 2020 +0200 Return None when no position state (#157) commit 6655d38 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 12:07:59 2020 +0200 Fix should_wait return value (#156) commit 34b6832 Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 10:05:53 2020 +0200 Add cycle support for the cover platform (#147) commit 2346ffd Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 10:02:19 2020 +0200 Remove return from `apply_action` (#154) commit ad90ae8 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 08:17:22 2020 +0200 Add support for 'screen' uiClass. (#153) Closes github issue: #149 commit 3cc86dc Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Thu Jul 16 15:07:08 2020 +0200 Add helper functions select_command and select_state (#148) * Add helper functions select_command and select_state Github issue #110
iMicknl
added a commit
that referenced
this pull request
Jul 20, 2020
commit 4e9e33d Author: vlebourl <vlebourl@gmail.com> Date: Mon Jul 20 11:36:36 2020 +0200 Removed private properties. * Removed private properties. * Removed update methods. * Removed __init__ when possible. * Moved classes to their own files. Github Issue: #151 commit 5b7a2fd Author: vlebourl <vlebourl@gmail.com> Date: Mon Jul 20 10:40:05 2020 +0200 Refactor climate.py * Added a base class for common properties. * Added setters to Somfy Smart Thermostat. Github Issue: #151 commit 00af2a1 Merge: 56ecc3e 997ccb0 Author: vlebourl <vlebourl@gmail.com> Date: Mon Jul 20 09:41:31 2020 +0200 Merge branch 'master' into enhancement/refactor_climate_#151 commit 997ccb0 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Mon Jul 20 09:41:08 2020 +0200 Fix rescheduling update. (#158) * Fix rescheduling update. Replacing `self.schedule_update_ha_state(True)` by `self.hass.add_job(self.update)` actually does reschedule the update in a non blocking way. Adding `self.schedule_update_ha_state()` at the end tells HA to write down the newly polled state. * Add throttle to prevent too many calls. commit db7e26c Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 21:59:38 2020 +0200 Return None when no position state (#157) commit 56ecc3e Author: vlebourl <vlebourl@gmail.com> Date: Fri Jul 17 17:20:48 2020 +0200 first part of Somfy Smart Thermostat. commit aebb31b Author: Thibaut Etienne <thibaut@etienne.pw> Date: Fri Jul 17 12:13:28 2020 +0200 Return None when no position state commit b7502fc Author: vlebourl <vlebourl@gmail.com> Date: Fri Jul 17 16:40:21 2020 +0200 Remove options flow. commit 69a6c7f Author: vlebourl <vlebourl@gmail.com> Date: Fri Jul 17 16:11:57 2020 +0200 Remove unused constants. commit d64096c Author: vlebourl <vlebourl@gmail.com> Date: Fri Jul 17 16:10:29 2020 +0200 First commit for AtlanticElectricalHeater. commit 6655d38 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 12:07:59 2020 +0200 Fix should_wait return value (#156) commit 34b6832 Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 10:05:53 2020 +0200 Add cycle support for the cover platform (#147) commit 2346ffd Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 10:02:19 2020 +0200 Remove return from `apply_action` (#154) commit ad90ae8 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 08:17:22 2020 +0200 Add support for 'screen' uiClass. (#153) Closes github issue: #149 commit 3cc86dc Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Thu Jul 16 15:07:08 2020 +0200 Add helper functions select_command and select_state (#148) * Add helper functions select_command and select_state Github issue #110
iMicknl
added a commit
that referenced
this pull request
Jul 20, 2020
commit 997ccb0 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Mon Jul 20 09:41:08 2020 +0200 Fix rescheduling update. (#158) * Fix rescheduling update. Replacing `self.schedule_update_ha_state(True)` by `self.hass.add_job(self.update)` actually does reschedule the update in a non blocking way. Adding `self.schedule_update_ha_state()` at the end tells HA to write down the newly polled state. * Add throttle to prevent too many calls. commit db7e26c Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 21:59:38 2020 +0200 Return None when no position state (#157) commit 6655d38 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 12:07:59 2020 +0200 Fix should_wait return value (#156) commit 34b6832 Author: tetienne <thibaut@etienne.pw> Date: Fri Jul 17 10:05:53 2020 +0200 Add cycle support for the cover platform (#147) commit 2346ffd Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 10:02:19 2020 +0200 Remove return from `apply_action` (#154) commit ad90ae8 Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Fri Jul 17 08:17:22 2020 +0200 Add support for 'screen' uiClass. (#153) Closes github issue: #149 commit 3cc86dc Author: Vincent Le Bourlot <vlebourl@gmail.com> Date: Thu Jul 16 15:07:08 2020 +0200 Add helper functions select_command and select_state (#148) * Add helper functions select_command and select_state Github issue #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_actionshould not return anything.