Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execute_command call #176

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fix execute_command call #176

merged 1 commit into from
Jul 27, 2020

Conversation

tetienne
Copy link
Collaborator

@tetienne tetienne commented Jul 27, 2020 •
edited
Loading

Fix #173

@github-actions github-actions bot added the bug Something isn't working label Jul 27, 2020
iMicknl
iMicknl reviewed Jul 27, 2020
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to merge if you fix the CI fail.

vlebourl
vlebourl approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@vlebourl vlebourl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provided the linters check pass.

@tetienne tetienne merged commit b490d79 into master Jul 27, 2020
@tetienne tetienne deleted the fix/execute_command branch July 27, 2020 12:03
iMicknl added a commit that referenced this pull request Jul 27, 2020
@iMicknl
Squashed commit of the following:
fb16f84 
commit c7ca453
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Mon Jul 27 16:32:04 2020 +0200

    Add device attributes to attributes (#180)

commit 0883cf6
Author: tetienne <thibaut@etienne.pw>
Date:   Mon Jul 27 14:14:38 2020 +0200

    Fix assumed state (#178)

commit b490d79
Author: tetienne <thibaut@etienne.pw>
Date:   Mon Jul 27 14:02:58 2020 +0200

    Fix execute_command call (#176)

commit 9560cfa
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sun Jul 26 13:01:16 2020 +0200

    Add more ui_classes and sort them alphabetically (#168)

commit b01f2ca
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sun Jul 26 12:53:15 2020 +0200

    Improve support for GasSensor, ThermalEnergySensor, WaterSensor and add support for Siren Status (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMicknl iMicknl iMicknl left review comments

@vlebourl vlebourl vlebourl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cover/set_cover_position fails
3 participants
@tetienne @iMicknl @vlebourl