-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable position for AdjustableSlatsRollerShutter devices #192
Merged
iMicknl
merged 1 commit into
master
from
enhancement/improve_AdjustableSlatsRollerShutter
Jul 29, 2020
Merged
Enable position for AdjustableSlatsRollerShutter devices #192
iMicknl
merged 1 commit into
master
from
enhancement/improve_AdjustableSlatsRollerShutter
Jul 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetienne
approved these changes
Jul 29, 2020
@iMicknl Do you remember why we needed this? The device you linked also exposed ClosureState. {
"commands": [
{
"commandName": "advancedRefresh",
"nparams": 1
},
{
"commandName": "close",
"nparams": 0
},
{
"commandName": "delayedStopIdentify",
"nparams": 1
},
{
"commandName": "down",
"nparams": 0
},
{
"commandName": "getName",
"nparams": 0
},
{
"commandName": "identify",
"nparams": 0
},
{
"commandName": "open",
"nparams": 0
},
{
"commandName": "setClosureAndOrientation",
"nparams": 2
},
{
"commandName": "setClosure",
"nparams": 1
},
{
"commandName": "setClosureOrOrientation",
"nparams": 2
},
{
"commandName": "setClosureOrRockerPosition",
"nparams": 1
},
{
"commandName": "setDeployment",
"nparams": 1
},
{
"commandName": "setName",
"nparams": 1
},
{
"commandName": "setRockerPosition",
"nparams": 0
},
{
"commandName": "setOrientation",
"nparams": 1
},
{
"commandName": "startIdentify",
"nparams": 0
},
{
"commandName": "stop",
"nparams": 0
},
{
"commandName": "stopIdentify",
"nparams": 0
},
{
"commandName": "up",
"nparams": 0
},
{
"commandName": "wink",
"nparams": 1
},
{
"commandName": "runManufacturerSettingsCommand",
"nparams": 2
},
{
"commandName": "keepOneWayControllersAndDeleteNode",
"nparams": 0
},
{
"commandName": "pairOneWayController",
"nparams": 2
},
{
"commandName": "setConfigState",
"nparams": 1
},
{
"commandName": "unpairAllOneWayControllersAndDeleteNode",
"nparams": 0
},
{
"commandName": "unpairAllOneWayControllers",
"nparams": 0
},
{
"commandName": "unpairOneWayController",
"nparams": 2
}
],
"states": [
{
"type": "ContinuousState",
"qualifiedName": "core:ClosureOrRockerPositionState"
},
{
"type": "ContinuousState",
"qualifiedName": "core:ClosureState"
},
{
"type": "DiscreteState",
"values": [
"good",
"low",
"normal",
"verylow"
],
"qualifiedName": "core:DiscreteRSSILevelState"
},
{
"type": "DataState",
"qualifiedName": "core:ManufacturerSettingsState"
},
{
"type": "DiscreteState",
"values": [
"false",
"true"
],
"qualifiedName": "core:MovingState"
},
{
"type": "DataState",
"qualifiedName": "core:NameState"
},
{
"type": "ContinuousState",
"qualifiedName": "core:PriorityLockTimerState"
},
{
"type": "ContinuousState",
"qualifiedName": "core:RSSILevelState"
},
{
"type": "ContinuousState",
"qualifiedName": "core:SlateOrientationState"
},
{
"type": "DiscreteState",
"values": [
"available",
"unavailable"
],
"qualifiedName": "core:StatusState"
},
{
"type": "ContinuousState",
"qualifiedName": "core:TargetClosureState"
},
{
"type": "DiscreteState",
"values": [
"comfortLevel1",
"comfortLevel2",
"comfortLevel3",
"comfortLevel4",
"environmentProtection",
"humanProtection",
"userLevel1",
"userLevel2"
],
"qualifiedName": "io:PriorityLockLevelState"
},
{
"type": "DiscreteState",
"values": [
"LSC",
"SAAC",
"SFC",
"UPS",
"externalGateway",
"localUser",
"myself",
"rain",
"security",
"temperature",
"timer",
"user",
"wind"
],
"qualifiedName": "io:PriorityLockOriginatorState"
}
],
"dataProperties": [
{
"value": "500",
"qualifiedName": "core:identifyInterval"
}
],
"widgetName": "PositionableOrProgressiveOrientableRollerShutter",
"uiProfiles": [
"StatefulOrientableAndCloseableShutter",
"StatefulOrientableAndCloseable",
"OrientableAndCloseable",
"OpenClose"
],
"uiClass": "AdjustableSlatsRollerShutter",
"qualifiedName": "io:VRHollaIOComponent",
"type": "ACTUATOR"
} |
@tetienne no clue... I believe that I pulled this device definition from the internet :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple AdjustableSlatsRollerShutter components are using
core:ClosureOrRockerPositionState
for the position.No commands need to be changed, since the integration supports
setClosure
already.https://www.tahomalink.com/enduser-mobile-web/enduserAPI/reference/controllable/io:VRHollaIOComponent