Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable position for AdjustableSlatsRollerShutter devices #192

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jul 29, 2020

Multiple AdjustableSlatsRollerShutter components are using core:ClosureOrRockerPositionState for the position.

No commands need to be changed, since the integration supports setClosure already.

https://www.tahomalink.com/enduser-mobile-web/enduserAPI/reference/controllable/io:VRHollaIOComponent

@iMicknl iMicknl self-assigned this Jul 29, 2020
@github-actions github-actions bot added the enhancement New feature or request label Jul 29, 2020
@iMicknl iMicknl merged commit 536864c into master Jul 29, 2020
@iMicknl iMicknl deleted the enhancement/improve_AdjustableSlatsRollerShutter branch July 29, 2020 21:12
@tetienne
Copy link
Collaborator

@iMicknl Do you remember why we needed this? The device you linked also exposed ClosureState.

{
  "commands": [
    {
      "commandName": "advancedRefresh",
      "nparams": 1
    },
    {
      "commandName": "close",
      "nparams": 0
    },
    {
      "commandName": "delayedStopIdentify",
      "nparams": 1
    },
    {
      "commandName": "down",
      "nparams": 0
    },
    {
      "commandName": "getName",
      "nparams": 0
    },
    {
      "commandName": "identify",
      "nparams": 0
    },
    {
      "commandName": "open",
      "nparams": 0
    },
    {
      "commandName": "setClosureAndOrientation",
      "nparams": 2
    },
    {
      "commandName": "setClosure",
      "nparams": 1
    },
    {
      "commandName": "setClosureOrOrientation",
      "nparams": 2
    },
    {
      "commandName": "setClosureOrRockerPosition",
      "nparams": 1
    },
    {
      "commandName": "setDeployment",
      "nparams": 1
    },
    {
      "commandName": "setName",
      "nparams": 1
    },
    {
      "commandName": "setRockerPosition",
      "nparams": 0
    },
    {
      "commandName": "setOrientation",
      "nparams": 1
    },
    {
      "commandName": "startIdentify",
      "nparams": 0
    },
    {
      "commandName": "stop",
      "nparams": 0
    },
    {
      "commandName": "stopIdentify",
      "nparams": 0
    },
    {
      "commandName": "up",
      "nparams": 0
    },
    {
      "commandName": "wink",
      "nparams": 1
    },
    {
      "commandName": "runManufacturerSettingsCommand",
      "nparams": 2
    },
    {
      "commandName": "keepOneWayControllersAndDeleteNode",
      "nparams": 0
    },
    {
      "commandName": "pairOneWayController",
      "nparams": 2
    },
    {
      "commandName": "setConfigState",
      "nparams": 1
    },
    {
      "commandName": "unpairAllOneWayControllersAndDeleteNode",
      "nparams": 0
    },
    {
      "commandName": "unpairAllOneWayControllers",
      "nparams": 0
    },
    {
      "commandName": "unpairOneWayController",
      "nparams": 2
    }
  ],
  "states": [
    {
      "type": "ContinuousState",
      "qualifiedName": "core:ClosureOrRockerPositionState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:ClosureState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "good",
        "low",
        "normal",
        "verylow"
      ],
      "qualifiedName": "core:DiscreteRSSILevelState"
    },
    {
      "type": "DataState",
      "qualifiedName": "core:ManufacturerSettingsState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "false",
        "true"
      ],
      "qualifiedName": "core:MovingState"
    },
    {
      "type": "DataState",
      "qualifiedName": "core:NameState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:PriorityLockTimerState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:RSSILevelState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:SlateOrientationState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "available",
        "unavailable"
      ],
      "qualifiedName": "core:StatusState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:TargetClosureState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "comfortLevel1",
        "comfortLevel2",
        "comfortLevel3",
        "comfortLevel4",
        "environmentProtection",
        "humanProtection",
        "userLevel1",
        "userLevel2"
      ],
      "qualifiedName": "io:PriorityLockLevelState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "LSC",
        "SAAC",
        "SFC",
        "UPS",
        "externalGateway",
        "localUser",
        "myself",
        "rain",
        "security",
        "temperature",
        "timer",
        "user",
        "wind"
      ],
      "qualifiedName": "io:PriorityLockOriginatorState"
    }
  ],
  "dataProperties": [
    {
      "value": "500",
      "qualifiedName": "core:identifyInterval"
    }
  ],
  "widgetName": "PositionableOrProgressiveOrientableRollerShutter",
  "uiProfiles": [
    "StatefulOrientableAndCloseableShutter",
    "StatefulOrientableAndCloseable",
    "OrientableAndCloseable",
    "OpenClose"
  ],
  "uiClass": "AdjustableSlatsRollerShutter",
  "qualifiedName": "io:VRHollaIOComponent",
  "type": "ACTUATOR"
}

@iMicknl
Copy link
Owner Author

iMicknl commented Apr 25, 2021

@tetienne no clue... I believe that I pulled this device definition from the internet :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform: cover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants