Add my service for light and cover devices
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetienne
approved these changes
Aug 24, 2020
|
Yes, sadly it seems we haven't the choice to repeat the code. |
vlebourl
approved these changes
Aug 24, 2020
iMicknl
added a commit
that referenced
this pull request
Aug 27, 2020
commit 7af2d98 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Thu Aug 27 15:06:33 2020 +0200 Add custom session, handle HTTP_CONNECT_ERRORS and retry on ServerDisconnectedError (#237) commit ee58468 Author: Mick Vleeshouwer <mick@imick.nl> Date: Mon Aug 24 11:03:59 2020 +0200 Add `my` service for light and cover devices (#236)
iMicknl
added a commit
that referenced
this pull request
Aug 27, 2020
commit 7af2d98 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Thu Aug 27 15:06:33 2020 +0200 Add custom session, handle HTTP_CONNECT_ERRORS and retry on ServerDisconnectedError (#237) commit ee58468 Author: Mick Vleeshouwer <mick@imick.nl> Date: Mon Aug 24 11:03:59 2020 +0200 Add `my` service for light and cover devices (#236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220
For now, I did register
tahoma.cover_myandtahoma.light_mysince I was not able to linktahoma.myto multiple entities...I tried creating tahoma.cover.my and tahoma.light.my as well, however in this case the services.yaml doesn't get read correctly.