Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unjustified canceled trains #323

Closed
jncn opened this issue Oct 24, 2017 · 6 comments
Closed

Unjustified canceled trains #323

jncn opened this issue Oct 24, 2017 · 6 comments
Assignees
Labels

Comments

@jncn
Copy link
Contributor

@jncn jncn commented Oct 24, 2017

For at least a week, some trains are displayed as canceled although they are not (see screenshot).
e.g. IC2435 and IC2436 https://api.irail.be/connections/?to=doornik&from=brussel-centraal

screen shot 2017-10-24 at 16 43 39

@Bertware Bertware self-assigned this Oct 24, 2017
@Bertware
Copy link
Member

@Bertware Bertware commented Oct 24, 2017

I know where this bug originates in the code, but I don't know what the NMBS data is at that point. It seems to be a temporary thing in the NMBS data, as it's correct now, so I have to see it at the very moment this bug occurs...

Bertware added a commit that referenced this issue Oct 24, 2017
@Bertware
Copy link
Member

@Bertware Bertware commented Oct 24, 2017

If you come accross this again, please add &debug to the end of the url. This will store the NMBS data on disk, so we can see the exact response later. Having one of those should be enough to resolve this issue

@jncn
Copy link
Contributor Author

@jncn jncn commented Oct 24, 2017

Right now: IC740 https://api.irail.be/connections/?to=gent-sint-pieter&from=kortrijk
I've added the &debug 😉

@Bertware
Copy link
Member

@Bertware Bertware commented Oct 24, 2017

Got it!

Bertware added a commit that referenced this issue Oct 24, 2017
@Bertware
Copy link
Member

@Bertware Bertware commented Oct 24, 2017

The fix is now in production. I've left the debug switch there for now, in case they add another enum type to their raw data and we need to fix it again.

@jncn
Copy link
Contributor Author

@jncn jncn commented Oct 24, 2017

Alright, you're faster than your shadow 🙂 Thanks, @Bertware!

@Bertware Bertware closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.