Support derivation for generic types #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
majk-p
force-pushed
the
support-generics
branch
from
e2d86af
to
39cd09a
Compare
iRevive
reviewed
Jan 26, 2024
modules/core/src/test/scala/io/github/irevive/union/derivation/ComplexTypeDerivationSuite.scala
Outdated
Show resolved
Hide resolved
iRevive
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the mapping to
typeSymbolinUnionDerivationmacro logic the parametric type got erased, leading to failing derivation for unions likeInt | MyType[String]. This PR fixes that by propagating more information down the line for implicit resolution,