Skip automatic deployment job if secrets aren't set (especially for forks) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctmbl
force-pushed
the
skip-deploy-on-fork
branch
2 times, most recently
from
dca6d38
to
6472b2c
Compare
ctmbl
force-pushed
the
skip-deploy-on-fork
branch
2 times, most recently
from
2fed1a5
to
948b08f
Compare
|
EDIT: since #57 (comment) I had to update this solution because some things were flawed I've been down the rabbit hole and it seems to be no nice way to do what I want to do here. TLDR:
Workflow syntax: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#env |
see DISCLAIMER comment add required secrets in comment
ctmbl
force-pushed
the
skip-deploy-on-fork
branch
from
948b08f
to
7d1b42a
Compare
On main branch the condition on the deploy step was: github.event_name == 'push' || github.event_name == 'workflow_dispatch' It must be resolved given that we want to avoid triggering on forks (due to possibly missing secrets leading to failing workflow) it then become: (github.event_name == 'push' && github.event.repository.fork == 'false') || github.event_name == 'workflow_dispatch' <==> If it is a classic push: - on fork *do not* trigger deployment - on base repo trigger deployment But if it is manually triggered, execute deployment step anyway maybe we're on fork maybe we're not but this is user triggered so it the user's responsability anyway.
ctmbl
added a commit
that referenced
this pull request
Apr 14, 2024
see DISCLAIMER comment
add required secrets in comment
On main branch the condition on the deploy step was:
github.event_name == 'push' || github.event_name == 'workflow_dispatch'
It must be resolved given that we want to avoid triggering on forks (due
to possibly missing secrets leading to failing workflow)
it then become:
(github.event_name == 'push' && github.event.repository.fork == 'false') || github.event_name == 'workflow_dispatch'
<==>
If it is a classic push:
- on fork *do not* trigger deployment
- on base repo trigger deployment
But if it is manually triggered, execute deployment step anyway
maybe we're on fork maybe we're not but this is user triggered so it the
user's responsability anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test it properly i have to push this comit to my main branch on my own fork
I also added a smoke test fake secret to test it here