Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update online game article #41

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

ZynoXelek
Copy link
Contributor

A small PR to update the ToC of the article with the main objective of making it shorter.

@ZynoXelek ZynoXelek requested a review from ctmbl April 2, 2024 16:18
@ZynoXelek ZynoXelek self-assigned this Apr 2, 2024
Copy link
Contributor

@ctmbl ctmbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pruning in my opinion 😉

While we're doing an update of this post maybe you could also add these:

  • a link to the repo at the very beginning 🥲 this seems obvious but I think that for now there isn't any link except to the readme
  • at every code block (or at least at main ones) a permalink to the code like that:

server.py:

def main():
    """Main function launching the parallel threads to manage the different aspects of the server.
    """
    global MAINSOCKET
    ...
    ```
    
    But these are just ideas!

src/content/posts/multiplayer_online_game.md Show resolved Hide resolved
@ctmbl
Copy link
Contributor

ctmbl commented Apr 5, 2024

also @ZynoXelek you should fetch new changes from the repo, rebase your branch and finally force push to this PR's branch. Because a lot of commits are listed here uselessly 😉

Copy link
Contributor

@ctmbl ctmbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice update!
ready to merge 🚀

@ZynoXelek ZynoXelek merged commit bd17ae1 into iScsc:main Apr 7, 2024
4 checks passed
@ZynoXelek ZynoXelek deleted the Update-Online-Game-Article branch April 7, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants