Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issue: action fetches wrong repo #90

Closed
wants to merge 1 commit into from
Closed

Fix CI issue: action fetches wrong repo #90

wants to merge 1 commit into from

Conversation

atxr
Copy link
Contributor

@atxr atxr commented Apr 14, 2023 •
edited
Loading

This PR will solve the CI issue by adding the right repo to checkout.
Currently, when opening a PR from a fork, the prettier action fails to checkout the branch because it looks for it in iscsc/iscsc.fr instead of the forked repo.

I tested the fix with my fork.

@atxr atxr changed the title Add repo to CI Fix CI issue: action fetches wrong repo Apr 14, 2023
@atxr atxr marked this pull request as ready for review April 14, 2023 17:14
@atxr atxr requested review from amtoine and ctmbl April 14, 2023 17:15
@atxr atxr self-assigned this Apr 14, 2023
@atxr atxr added bug Something isn't working repo issue An issue that address the whole project/repo not a specific code feature Priority: Medium The Issue must be addressed as soon as possible labels Apr 14, 2023
amtoine
amtoine approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm but i've no idea why this does not work in this repo 😆

this is the very first and only time i've seen such a strange behaviour...
could there be a repo setting messing with us? 👀

@amtoine amtoine self-requested a review April 14, 2023 17:47
@amtoine
Copy link
Member

amtoine commented Apr 14, 2023

actually, #91 solves the issue i think

@amtoine amtoine closed this Apr 14, 2023
@atxr atxr deleted the fix_ci branch April 15, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctmbl ctmbl Awaiting requested review from ctmbl

@amtoine amtoine Awaiting requested review from amtoine

Assignees

@atxr atxr

Labels
bug Something isn't working Priority: Medium The Issue must be addressed as soon as possible repo issue An issue that address the whole project/repo not a specific code feature
Projects
iScsc website
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atxr @amtoine