-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created table of contents, corrected spelling and punctuation #96
Conversation
OlaPom
commented
Apr 24, 2023
- corrected minor stylistic and spelling errors
- added section numbers
- created a table of contents
Issue #79 |
you can use https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue directly in the PR description if you want to link it yourself 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple and great, looks good to me 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I added a few suggestion I already had in mind 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
I've been looking for instructions, but I need an explanation. Can this be done with GitHub Actions or do I need to install some tools? (Because if it's the latter, I'm afraid my technical skills may not be enough). |
this should be added in the repo 👍
yeah we chose not to commit in the name of our contributors, to control what's going on in the PR branches 😌 npx prettier --write . |
This can't be done with GitHub Actions, because we don't want automated tools to modify our code without our approbation. First you need to install PS: to remove it afterwards (if you want to), run |
@OlaPom |
@ctmbl jinx 😏 |
Thank you for the instructions! Let me try 💪 |
No problem, looking forward to see your commit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution and for correcting my (stupid) English typos 🙂
You did a good job 🥳
We just wait for prettier
now, and then we will merge your work 🥇
(don't hesitate to reach us if you experience any trouble with prettier)
I installed
I’m on Windows. I googled this error, and it may have sth to do with the quotes. I copied the readme file to another folder and was able to format it with |
@OlaPom I ran prettier on my machine and created a pull request on your branch |
Like @atxr I managed to run it on Linux, sorry it doesn't work on Windows, but tks for testing it at least we'll be able to solve it now 🥲 Once you'll have merged atxr's PR on your repo we'll merge this one, in any case, tks for your contribution! |
Run prettier action
Ok. I think it's done. Thanks for help! |
CI did pass 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for contributing! 💯