-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced .png drawables with vector assets where possible #1100
Conversation
We have to check how that works license-wise, given that some of these files are under the Apache license with LHT is under GPL3. |
The ic_notification.xml was actually created by converting the intro_icon_1.png to .svg using an online converter, so I'm not sure which license applies to it. |
And I also found this: https://www.apache.org/licenses/GPL-compatibility.html |
Thank you for the PR, @kalina559. It looks good. I'll merge after the checks are done. On a side note, I have just realized that many of these icons are no longer used within the app. If you would like to submit a PR removing these unused resources, that would also be very welcome. |
Should I do it in a separate PR or just add it to this one? |
@kalina559 That can be a separate PR. I've just merged this one. Thanks again! |
Replaced .png drawables with vector assets where possible
All the icons that could be found in Android Studio clipart gallery have been replaced with their .svg versions. Resolves #701