Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced .png drawables with vector assets where possible #1100

Merged
merged 14 commits into from
Sep 11, 2021

Conversation

kalina559
Copy link
Collaborator

All the icons that could be found in Android Studio clipart gallery have been replaced with their .svg versions. Resolves #701

@hiqua
Copy link
Collaborator

hiqua commented Sep 8, 2021

We have to check how that works license-wise, given that some of these files are under the Apache license with LHT is under GPL3.

@kalina559
Copy link
Collaborator Author

The ic_notification.xml was actually created by converting the intro_icon_1.png to .svg using an online converter, so I'm not sure which license applies to it.

@kalina559
Copy link
Collaborator Author

And I also found this: https://www.apache.org/licenses/GPL-compatibility.html

@iSoron
Copy link
Owner

iSoron commented Sep 11, 2021

Thank you for the PR, @kalina559. It looks good. I'll merge after the checks are done.

On a side note, I have just realized that many of these icons are no longer used within the app. If you would like to submit a PR removing these unused resources, that would also be very welcome.

@kalina559
Copy link
Collaborator Author

Should I do it in a separate PR or just add it to this one?

@iSoron iSoron merged commit 2ab6c39 into iSoron:dev Sep 11, 2021
@iSoron
Copy link
Owner

iSoron commented Sep 11, 2021

@kalina559 That can be a separate PR. I've just merged this one. Thanks again!

sgallese pushed a commit to sgallese/uhabits that referenced this pull request Sep 20, 2021
Replaced .png drawables with vector assets where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bitmap icons by vector drawables
3 participants