Handle numerical habits from HabitBull #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiqua
force-pushed
the
fix_habit_bull_numerical
branch
2 times, most recently
from
9c9fb26
to
b19f9ab
Compare
2 tasks
hiqua
force-pushed
the
fix_habit_bull_numerical
branch
from
b19f9ab
to
a07a50e
Compare
2 tasks
|
Thank you for the PR, @hiqua. I will review it soon. |
|
Everything looks good, @hiqua. A bit surprising to see that the CSV doesn't have anything to indicate that the habit is numeric, but I think your idea here of checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.