Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #26 #37

Closed
wants to merge 3 commits into from
Closed

Fixed #26 #37

wants to merge 3 commits into from

Conversation

tarik02
Copy link

@tarik02 tarik02 commented Aug 31, 2016

Fixed "Too many open files". You can see here some info about this: http://stackoverflow.com/questions/4289447/java-too-many-open-files. This requires some testers.

} catch (Exception e) {
this.logException(e);
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct this formatting.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dktapps dktapps mentioned this pull request Aug 31, 2016
@ishitatsuyuki
Copy link
Member

Well, your linked answer mentions a more graceful solution. Why not use that?

@ishitatsuyuki ishitatsuyuki changed the title Fixed https://github.com/iTXTech/Nemisys/issues/26 Fixed #26 Aug 31, 2016
@tarik02
Copy link
Author

tarik02 commented Aug 31, 2016

@ishitatsuyuki, because I'm want to log errors from that.

@ishitatsuyuki
Copy link
Member

To do that in correct way, use Throwable.getSuppressed. Basically there shouldn't be errors closing, so beautiful code should be more important here.

@tarik02
Copy link
Author

tarik02 commented Sep 3, 2016

Tested: this not helps. Close.

@tarik02 tarik02 closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants