refacto(cache): ditch Map() in Cache for simple tree #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous Cache was working on a single Map, which can become really slow and big after a few minutes of navigation in iTowns. Now, the Cache is composed of a single tree, that can contain node up to 3 levels. It simplifies things attached to a layer, a source or others things like a zoom value. Instead of having a complex string composed with all those information, it now uses several key accross all the node of the Cache. In term of performance, the proposed implementation is 20 times faster than the previous one.
gchoqueux
reviewed
Dec 3, 2019
gchoqueux
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Cache was working on a single Map, which can become really
slow and big after a few minutes of navigation in iTowns.
Now, the Cache is composed of a single tree, that can contain node up
to 3 levels. It simplifies things attached to a layer, a source or
others things like a zoom value. Instead of having a complex string
composed with all those information, it now uses several key accross all
the node of the Cache.
In term of performance, the proposed implementation is 20 times faster
than the previous one.