Add a Toolbar based on iTwinUI components #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardasB
changed the title
This was referenced Mar 19, 2024
ignas-k
requested changes
Mar 21, 2024
saskliutas
approved these changes
Mar 21, 2024
ui/appui-react/src/appui-react/preview/new-toolbars/useOverflow.tsx
Outdated
Show resolved
Hide resolved
ignas-k
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a
newToolbarspreview feature which when enabled replaces existingToolbarcomponents with iTwinUI based toolbars. New toolbars currently have refined visual changes and accessibility improvements:Slimmer design
Single column toolbar group item
Renders expandable submenu instead of a nested menu for toolbar group items
Styled labels
Fixed tab/shift+tab navigation (arrow keys can be used to navigate the toolbar group item)
Testing
Added additional storybook stories. Tested manually via standalone test-app.