Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG icon alignment in ContextMenuItem #840

Merged
merged 7 commits into from
May 9, 2024
Merged

Fix SVG icon alignment in ContextMenuItem #840

merged 7 commits into from
May 9, 2024

Conversation

GerardasB
Copy link
Collaborator

Changes

This PR fixes:

  • SVG icon alignment in ContextMenuItem component.
  • ContextSubMenu to correctly render provided SVG icon.

Testing

Added additional story.

@GerardasB GerardasB requested a review from a team as a code owner May 9, 2024 07:45
@GerardasB
Copy link
Collaborator Author

@FlyersPh9 I am thinking about deprecating ContextMenu, GlobalContextMenu, and related components in favor of https://itwinui.bentley.com/docs/dropdownmenu, unless we can think of different visuals or additional features that the context menu should support.

@GerardasB GerardasB merged commit 02cf010 into master May 9, 2024
18 of 20 checks passed
@GerardasB GerardasB deleted the context-menu branch May 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignas-k ignas-k ignas-k approved these changes

@mdastous-bentley mdastous-bentley Awaiting requested review from mdastous-bentley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerardasB @ignas-k