Fix extension exports config #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashincontrol
requested review from
paulius-valiunas,
MichaelBelousov,
ben-polinsky and
aruniverse
as code owners
aruniverse
approved these changes
Jul 14, 2023
anmolshres98
approved these changes
Jul 14, 2023
ben-polinsky
approved these changes
Jul 14, 2023
|
@yashincontrol can you also create an issue to write tests so that this can be caught in the future, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the @typescript-eslint plugin and removed the react plugins as they are not needed. This would help fix the extract-api errors on core and ensure that the extract-extension-api behaves the same way as before. After this PR is merged we would need a new dev version because the core repo is switching over to using the new flat config system. iTwin/itwinjs-core#5731